Menu
▾
▴
#602 CURL timeout bug with SOCKS & segmentation fault
Hi,
I've fixed the following bugs:
1. (Known as 34) The SOCKS connection codes don't
properly acknowledge (connect) timeouts. It worked like
with timeout = 0.
2. Segmentation fault in the case when SOCKS requires
authentication and you did not specify username:password.
I've tested it on 5 servers within 20 days and seems
that everything is ok.
Please review.
Patch for lib/curl.c file
Logged In: YES
user_id=1589629
Patch is for lib/url.c not for lib/curl.c
Logged In: YES
user_id=1110
Thanks, I've committed it just because it improves the
situation. I don't think it is a nice way of solving the
problem - as it makes a blocking wait.
Also, please beware next time that we are C89 compliant (i,e
no // comments) and please pay attention to curl style
source indenting.
If you tell me your real name, I'll give you proper credit
for the fix.
Logged In: YES
user_id=1589629
My real name is Dmitry Rechkin
Logged In: YES
user_id=1578091
I think I may be encountering the SOCKS timeout bug in my
application but there is not sufficient information here for
me to:
a) convince myself that this bug is/isn't causing my problem
b) determine the consequences of using the patch with a
blocking wait
Is there somewhere else where I can find this bug discussed
in more detail?
Logged In: YES
user_id=1110
zoyd2k, use the curl-library mailing list