cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Curl 7.16.x and multi interface

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sun, 11 Mar 2007 23:44:07 +0100 (CET)

On Sun, 11 Mar 2007, Eygene Ryabinkin wrote:

> Thank you! If the patch was right (I was not sure) maybe it will be better
> to move the NULLification out to the end of Curl_done to make function's
> semantics a bit better: if we're making the connection being done, then
> we're signalling the caller no matter if we're closing the connection,
> leaving it opened for later reusal or something else.
>
> Sorry, it came to my mind just today.

Yeah, no need to NULL it on two different places since the outcome is that it
will always be NULLed anyway.

The fix is the right thing to do since the connection is marked "unused" from
that point and must not be used at all again without properly being "taken"
with the correct function call.

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2007-03-12