cURL
Haxx ad
libcurl

curl's project page on SourceForge.net

Sponsors:
Haxx

cURL > Mailing List > Monthly Index > Single Mail

curl-library Mailing List Archives

User in URL with no_proxy - patch

From: James Bursa <james_at_zamez.org>
Date: Fri, 15 May 2009 07:07:17 -0500

Fetching a URL with an embedded user and password when both the http_proxy and
no_proxy environment variables are set doesn't work correctly. For example:

$ export http_proxy=http://localhost:3128/
$ export no_proxy=192.168.1.1

This works as expected:

$ curl -v http://192.168.1.1/
* About to connect() to 192.168.1.1 port 80 (#0)

but this attempts to go through the proxy anyway:

$ curl -v http://u:p@192.168.1.1/
* About to connect() to proxy localhost port 3128 (#0)

I think the cause is the order of operations in create_conn(), which does
proxy detection before removing the user and password from conn->host.name.

The attached patch reorders the code to fix it. The reasoning behind this is:

1. ParseURLAndFillConnection() fills in conn->protostr and may also do
   conn->protocol |= PROT_MISSING
2. setup_connection_internals() uses conn->protostr and sets conn->protocol
3. parse_url_userpass() needs conn->protocol

so the patch keeps these in the same order, but moves them before proxy
detection so that proxy detection gets the conn->host.name altered by
parse_url_userpass().

This problem came up on the #curl IRC channel.

James

Received on 2009-05-15

These mail archives are generated by hypermail.

donate! Page updated November 12, 2010.
web site info

File upload with ASP.NET