cURL
Haxx ad
libcurl

curl's project page on SourceForge.net

Sponsors:
Haxx

cURL > Mailing List > Monthly Index > Single Mail

curl-library Mailing List Archives

Re: [Patch] Fix duplicated code in http.c

From: Julien Chaffraix <julien.chaffraix_at_gmail.com>
Date: Tue, 2 Feb 2010 11:17:26 -0800

On Tue, Feb 2, 2010 at 12:47 AM, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Tue, 2 Feb 2010, Julien Chaffraix wrote:
>
>> the attached patch removes a copy and paste issue in http.c.
>
> I think you were a bit too quick there. authhost and authproxy may look
> almost the same, but they are not and I think that function needs to deal
> with both properly!

Right! The 2 'if's that are nearly the same and the comment just has
one word that changes which confused me. I don't see how it can be
made less confusing though so just discard this rant.

>> As a bonus, there is a trivial comment fix for ftp.c.
>
> Thanks, I'll apply!

Thanks!

Regards,
Julien
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-02-02

These mail archives are generated by hypermail.

donate! Page updated November 12, 2010.
web site info

File upload with ASP.NET