cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] http_ntlm: support for NSS

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 29 Jun 2010 19:30:35 +0200 (CEST)

On Tue, 29 Jun 2010, Kamil Dudka wrote:

> Thanks for review! As for the test cases, unfortunately none of them covers
> the newly added code. If I comment out the MD4, MD5 and DES, all the tests
> still pass fine. It's probably a consequence of the following change:
>
> http://github.com/bagder/curl/commit/be285cd

Oh... :-/ And yes, now it comes back to me with full force. That's of course
annoying and limits our testing.

I wonder if it is time to make it possible to override the gethostname() call
within http_ntlm.c so that the test cases can run with a fixed local hostname
to allow better pattern matching and thus more complete algorithm checks.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-06-29