Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl_easy_reset does not reset status code #1017

Merged
merged 1 commit into from Sep 20, 2016
Merged

curl_easy_reset does not reset status code #1017

merged 1 commit into from Sep 20, 2016

Conversation

jay
Copy link
Member

@jay jay commented Sep 20, 2016

Running curl_easy_reset() on a handle does not reset CURLINFO_RESPONSE_CODE and CURLINFO_FILETIME to their original value (0 and "1970-01-01 01:00:00 CET" respectively) as promised by documentation.

@jay
Copy link
Member

jay commented Sep 16, 2016 •
edited

It looks like PureInfo is not reset in curl_easy_reset. It would probably be safer (and a little slower I bet) to just init a new handle and then copy over only what is documented. Anyway, tabling that for now, try this
edit: moved to https://github.com/curl/curl/compare/master...jay:fix_pureinfo_reset?expand=1

jay added a commit to jay/curl that referenced this pull request Sep 17, 2016
@jay
easy: Reset all statistical session info in curl_easy_reset
c4d8f06 
Bug: curl#1017
Reported-by: Jeroen Ooms
@bagder
Copy link
Member

bagder commented Sep 19, 2016

It'd be nice if we could repro this with a test and then verify the fix with it.

@jay
Copy link
Member

jay commented Sep 20, 2016

It'd be nice if we could repro this with a test and then verify the fix with it.

Done and I converted this to a PR. BTW I'm curious whether you receive notice when I do that.

@bagder
Copy link
Member

bagder commented Sep 20, 2016

No I don't. I think we basically only get notified when there's a comment added which is also why we don't get notified when people for example push a new commit in an existing PR etc

bagder
bagder approved these changes Sep 20, 2016
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it! =)

@jay jay merged commit 22cfeac into curl:master Sep 20, 2016
@jay
Copy link
Member

jay commented Sep 20, 2016

Thanks Jeroen, landed in 22cfeac.

@jay jay deleted the fix_pureinfo_reset branch September 20, 2016 06:09
@jay jay mentioned this pull request Feb 1, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jay @bagder