New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl: Add --retry-connrefused #1064
curl: Add --retry-connrefused #1064
Conversation
to consider ECONNREFUSED as a transient error.
@gnawhleinad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @bagder and @captain-caveman2k to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a feature we can merge. While I would like to see a test case added for this, I don't think our test infra makes that very easy.
Thanks! |
I think that could be misinterpreted, if you use it just as --retry-connrefused it doesn't work, so I think it should be adjusted
|
I changed the wording to that since there were no objections, landed in 4bda3e0. |
Improved the test run script in the following ways: * Now doesn't run Gradle in parallel anymore. This addresses the random class loading error and makes the service start up faster * Now automatically starts the tests when all services are up and running (no need to hit enter anymore) * Gives a more clear error message when something fails Note that this requires curl 7.51.1 or later, as we use curl/curl#1064
* YD-413 Improved start script Improved the test run script in the following ways: * Now doesn't run Gradle in parallel anymore. This addresses the random class loading error and makes the service start up faster * Now automatically starts the tests when all services are up and running (no need to hit enter anymore) * Gives a more clear error message when something fails Note that this requires curl 7.51.1 or later, as we use curl/curl#1064 * YD-413 Extra error checking Don't execute the tests if activity category loading fails.
to consider ECONNREFUSED as a transient error.
/cc: @andrewgaul (because #1036)
Any suggestions on a
tests/
addition for this change?