Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STARTTLS: Don't print response character in denied messages #1203

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Jan 12, 2017

Both IMAP and POP3 response characters are used internally, but when
appended to the STARTTLS denial message likely could confuse the user.


If nobody likes this there is still the problem if the response code is set -1 and that's printed as a character. At the very least I think we should do something like (ISALPHA(resp) ? resp : ' ') so that we don't print weird symbols. SMTP doesn't have this problem because libcurl is using its numeric response codes, so I've already fixed that separately in 4e6f483

Both IMAP and POP3 response characters are used internally, but when
appended to the STARTTLS denial message likely could confuse the user.
@mention-bot
Copy link

@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @yirkha to be potential reviewers.

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's get rid of those!

@jay jay closed this in a18db79 Jan 12, 2017
@jay jay deleted the starttls_no_denied_resp_char branch January 12, 2017 07:38
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants