authneg: add Content-Length:0 while negotiating auth #1242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the user supplied custom content-length header it should be set to 0 for both HTTPREQ_POST and HTTPREQ_PUT flows. This is what we do already in HTTPREQ_POST_FORM and what we did in the HTTPREQ_POST case prior to commit: afd288b Otherwise, if the user set custom header we'd end up skipping the content-length header altogether. Signed-off-by: Isaac Boukris <iboukris@gmail.com> Reported-by: Hölzl, Dominik <Dominik.Hoelzl@fabasoft.com>
|
Hi, here is a small reproducer based on Dominik's example on mailing-list (notice CL missing). #include <curl/curl.h>
int main(int argc, char *argv[])
{
CURLcode ret;
CURL *hnd;
hnd = curl_easy_init();
curl_easy_setopt(hnd, CURLOPT_URL, "http://localhost/");
curl_easy_setopt(hnd, CURLOPT_USERPWD, "x:y");
curl_easy_setopt(hnd, CURLOPT_HTTPAUTH, CURLAUTH_NTLM);
curl_easy_setopt(hnd, CURLOPT_VERBOSE, 1L);
curl_easy_setopt(hnd, CURLOPT_POSTFIELDS, "a=b");
struct curl_slist *headers = NULL;
headers = curl_slist_append(headers, "Content-Length: 3");
curl_easy_setopt(hnd, CURLOPT_HTTPHEADER, headers);
ret = curl_easy_perform(hnd);
curl_easy_cleanup(hnd);
return ret;
} |
bagder
approved these changes
Feb 7, 2017
MarcelRaad
approved these changes
Feb 10, 2017
|
Thanks Isaac I landed this with some tests and a modified commit message. |
|
Great, thank you all! |
|
Thank you for the quick response and fixing the problem! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the user supplied custom content-length header it
should be set to 0 for both HTTPREQ_POST and HTTPREQ_PUT flows.
This is what we do already in HTTPREQ_POST_FORM and what we
did in the HTTPREQ_POST case prior to commit:
afd288b
Otherwise, if the user set custom header we'd end up skipping
the content-length header altogether.
Signed-off-by: Isaac Boukris iboukris@gmail.com
Reported-by: Hölzl, Dominik Dominik.Hoelzl@fabasoft.com