Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: Allow disabling pthreads, fall back on Win32 threads #1260

Closed
wants to merge 1 commit into from
Closed

configure: Allow disabling pthreads, fall back on Win32 threads #1260

wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Feb 12, 2017

When the threaded resolver is used pthreads is the default, however this
change makes it possible to --disable-pthreads and then configure can
fall back on Win32 threads for native Windows builds.

Closes #xxxx

Context from ./configure --help output:

  --enable-threaded-resolver
                          Enable threaded resolver
  --disable-threaded-resolver
                          Disable threaded resolver
  --enable-pthreads       Enable POSIX threads (default for threaded resolver)
  --disable-pthreads      Disable POSIX threads

Context from curl_config.h when mingw ./configure --disable-pthreads --enable-threaded-resolver:

/* if you want POSIX threaded DNS lookup */
/* #undef USE_THREADS_POSIX */

/* if you want Win32 threaded DNS lookup */
#define USE_THREADS_WIN32 1

@jay
configure: Allow disabling pthreads, fall back on Win32 threads
c9fe4d1 
When the threaded resolver is used pthreads is the default, however this
change makes it possible to --disable-pthreads and then configure can
fall back on Win32 threads for native Windows builds.

Closes #xxxx
@mention-bot
Copy link

@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @dfandrich to be potential reviewers.

@jay jay added the build label Feb 12, 2017
bagder
bagder approved these changes Feb 13, 2017
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@jay jay closed this in c107128 Feb 14, 2017
@jay jay deleted the configure_add_pthreads_option branch February 14, 2017 07:58
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jay @mention-bot @bagder