New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test 1013 fails due to differences in protocol list #1262
Comments
It seems wrong on at least three ways:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I've been bitten by this issue often enough to finally start working on it. Assigning to myself so that I don't forget it once again.
|
`USE_WINDOWS_SSPI` without `USE_WIN32_CRYPTO` but with any other DES backend is fine, but was excluded before. This also fixes test 1013 as the condition for SMB support in configure.ac didn't match the condition in the source code. Now it does. Fixes curl#1262 Closes
I did this
Built a curl tool debug build using mingw32 msys:
Of note is
--enable-sspi
.Test 1013 failed
Of note is that
smb
andsmbs
are not listed protocols incurl --version
.Analysis
configure.ac uses this logic to decide whether to put smb in the
curl-config --protocols
protocol list:Of note is OPENSSL_ENABLED and USE_WINDOWS_SSPI variables are true so SMB and SMBS are in the
curl-config --protocols
protocol list.lib/version.c uses this logic to decide whether to put smb in the
curl --version
protocol list:Of note is
(!defined(USE_WINDOWS_SSPI) || defined(USE_WIN32_CRYPTO))
which is also the logic lib/smb.c is guaraded with. For thiscurl --version
case, which does not include smb, I've gotUSE_WINDOWS_SSPI
defined in my lib/curl_config.h but notUSE_WIN32_CRYPTO
, and as a result means smb won't be enabled.USE_WIN32_CRYPTO
is only defined in lib/config-win32.h (which is not used here since I'm using autotools generated config) and with this logic:I'm not sure why only config-win32 defines
USE_WIN32_CRYPTO
and only under those circumstances, and what is correct here.curl/libcurl version
master e1187c4 2017-02-11
operating system
Windows 7 x64 Enterprise
The text was updated successfully, but these errors were encountered: