Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idn2 tests 1035, 2046, 2047 fail #1277

Closed
ismail opened this issue Feb 22, 2017 · 2 comments
Closed

idn2 tests 1035, 2046, 2047 fail #1277

ismail opened this issue Feb 22, 2017 · 2 comments
Labels

Comments

@ismail
Copy link
Contributor

ismail commented Feb 22, 2017

Building on openSUSE Linux x86-64 with:

./configure --enable-ipv6
--with-ssl
--with-ca-fallback
--without-ca-path
--without-ca-bundle
--with-gssapi=/usr/lib/mit
--with-libidn2
--with-libssh2
--enable-hidden-symbols
--disable-static
--enable-threaded-resolver
--with-libmetalink

System has libidn2 01.6, the following tests fail:

test 1035...[HTTP over proxy with too long IDN host name]

1035: protocol FAILED:
--- log/check-expected 2017-02-22 10:32:08.792857714 +0000
+++ log/check-generated 2017-02-22 10:32:08.792857714 +0000
@@ -1,5 +1,5 @@
-GET http://too-long-IDN-name-c�rl-r�les-la-la-la-dee-da-flooby-nooby.local/page/1035 HTTP/1.1[CR][LF]
-Host: too-long-IDN-name-c�rl-r�les-la-la-la-dee-da-flooby-nooby.local[CR][LF]
+GET http://too-long-idn-name-crl-rles-la-la-la-dee-da-flooby-nooby.local/page/1035 HTTP/1.1[CR][LF]
+Host: too-long-idn-name-crl-rles-la-la-la-dee-da-flooby-nooby.local[CR][LF]
Accept: /[CR][LF]
Proxy-Connection: Keep-Alive[CR][LF]
[CR][LF]

test 2046...[Connection re-use with IDN host name]

2046: stdout FAILED:
--- log/check-expected 2017-02-22 10:33:36.165822947 +0000
+++ log/check-generated 2017-02-22 10:33:36.165822947 +0000
@@ -1,18 +1,6 @@
-HTTP/1.1 302 OK swsbounce[LF]
-Date: Thu, 09 Nov 2010 14:49:00 GMT[LF]
-Content-Length: 9[LF]
-Content-Type: text/plain[LF]
-Location: ./20460001[LF]
+0[LF]
+0[LF]
+0[LF]
+http://åäö.se:8990/2046[LF]
[LF]
-HTTP/1.1 200 OK[LF]
-Date: Thu, 09 Nov 2010 14:49:00 GMT[LF]
-Content-Length: 3[LF]
-Content-Type: text/plain; charset=us-ascii[LF]
-[LF]
-OK[LF]
-1[LF]
-1[LF]
-3[LF]
-http://åäö.se:8990/20460001[LF]
-text/plain; charset=us-ascii[LF]
-200[LF]
+000[LF]

test 2047...[Connection re-use with IDN host name over HTTP proxy]

2047: stdout FAILED:
--- log/check-expected 2017-02-22 10:33:36.221823533 +0000
+++ log/check-generated 2017-02-22 10:33:36.221823533 +0000
@@ -13,6 +13,6 @@
1[LF]
1[LF]
3[LF]
-http://xn--4cab6c.se/20470001[LF]
+http://.se/20470001[LF]
text/plain; charset=us-ascii[LF]
200[LF]

@ismail ismail changed the title idn2 tests 1035, 2046fail idn2 tests 1035, 2046, 2047 fail Feb 22, 2017
@bagder bagder added the URL label Feb 22, 2017
@bagder
Copy link
Member

bagder commented Feb 22, 2017

They still run fine for me with libidn2/0.16. What's your $LANG set to? I suppose this is idn2_lookup_ul() not handling the input the way we'd like. We should make the test script set the correct environment...

@ismail
Copy link
Contributor Author

ismail commented Feb 22, 2017

LANG is set to POSIX. Settings LANG to en_US.UTF-8 fixes the issue indeed.

@bagder bagder closed this as completed in 2bfe550 Feb 23, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants