Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix-socket: fix support for proxy-disabled builds #1289

Closed
wants to merge 1 commit into from

Conversation

iboukris
Copy link
Contributor

Regression introduced in:
0b8d682

Signed-off-by: Isaac Boukris iboukris@gmail.com
Figured-out-by: Jay Satiro
Reported-by: mccormickt12

Fixes: #1274

Regression introduced in:
0b8d682

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Figured-out-by: Jay Satiro
Reported-by: mccormickt12

Fixes: curl#1274
@mention-bot
Copy link

@Frenche, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @dfandrich and @captain-caveman2k to be potential reviewers.

jay pushed a commit that referenced this pull request Feb 25, 2017
Prior to this change if curl was built with Unix Socket support
(--enable-unix-sockets) and without Proxy support (--disable-proxy) then
unix socket options would erroneously be ignored.

Regression introduced in:
0b8d682

Bug: #1274
Reported-by: mccormickt12@users.noreply.github.com

Closes #1289
@jay jay closed this in 1f8023c Feb 25, 2017
@jay
Copy link
Member

jay commented Feb 25, 2017

Thanks

@iboukris
Copy link
Contributor Author

Thanks guys!

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants