New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Add CURL_CA_BUNDLE/CURL_CA_FALLBACK/CURL_CA_PATH #1461
Conversation
This is for symmetry with the autoconf generated curl_config.h.in
@webmaster128, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Sukender, @jzakrzewski and @billhoffman to be potential reviewers. |
Looks good to me except one thing.
|
Do I understand correctly that this a matter of taste with no impact on the behaviour of the script? Whenever possible, I'd prefer a general solution over a platform specific solution to avoid extra complexity that comes with case distinctions. When we set a bunch of possible paths, that do not exist on Windows, fine. But why not add a Windows path into the mix? The current code would allow that (but as you said, there is no such path). One thing that is let's me tent to a general solution is that "being on Windows" is not a black or white question. With Cygwin and MinGW in the mix, we need to support systems that are more or less like Windows, which makes feature testing much easier than OS distinctions. When you search the Internet for As far as I can see, there is no harm in finding and using given paths on a Windows-like system with a Unix-like file system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right. I generally try to avoid checks not needed on the platform out of habit.
To make sure I did test this PR on Windows now and the tests doesn't generate any message/warnings/errors so should be perfectly fine as is.
Thanks a lot for the extra set of eyes and comments. I'll merge this set! @webmaster128: just a request for the future: please check the commit message style we use and try to write the first line in that style. I've edited the commits now to adhere. |
No description provided.