Added compatibility options for older Windows versions and ability to build with static CRT. #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURL_STATIC_CRT and ENABLE_INET_PTON
bagder
reviewed
Jun 30, 2017
CMakeLists.txt
Outdated
| @@ -76,6 +76,9 @@ option(BUILD_CURL_EXE "Set to ON to build curl executable." ON) | |||
| option(CURL_STATICLIB "Set to ON to build libcurl with static linking." OFF) | |||
| option(ENABLE_ARES "Set to ON to enable c-ares support" OFF) | |||
| if(WIN32) | |||
| option(CURL_STATIC_CRT "Set to ON to build libcurl with static CRT on Windows (/MT)." OFF) | |||
| option(ENABLE_INET_PTON "Set to OFF to prevent usage of inet_pton on Windows. For compatability with Windows XP, Windows Server 2003 etc." ON) | |||
There was a problem hiding this comment.
Why a specific ENABLE_INET_PTON option? Are you building on a system version that has the function but you want it to run on older ones? Can we somehow get that message into the explanation for its purpose?
There was a problem hiding this comment.
Yes, that is precisely the case. How about something along these lines?
Set to OFF to prevent usage of inet_pton when building against modern SDKs while still requiring compatibility with older Windows versions, such as Windows XP, Windows Server 2003 etc
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.