Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Threads detection update. ref: #1702 #1719

Closed
wants to merge 1 commit into from
Closed

cmake: Threads detection update. ref: #1702 #1719

wants to merge 1 commit into from

Conversation

snikulov
Copy link
Member

@snikulov snikulov commented Aug 1, 2017

Some improvement for #1702.

  • make ENABLE_ARES and ENABLE_THREADED_RESOLVER (by default ENABLE_ARES will win if enabled)
  • enforce Threads package if ENABLE_THREADED_RESOLVER set to ON.
  • Variables will be set to ON according to CMake findings

@snikulov snikulov added the cmake label Aug 1, 2017
@mention-bot
Copy link

@snikulov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Sukender, @billhoffman and @ligfx to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.267% when pulling 0e93fab on snikulov:cmake_pthread_test into 0139545 on curl:master.

@bagder
Copy link
Member

bagder commented Aug 12, 2017

So what will the default resolver be if nothing is set by the user?

@snikulov
Copy link
Member Author

@bagder threaded.

@bagder bagder closed this in a905e88 Aug 13, 2017
@bagder
Copy link
Member

bagder commented Aug 13, 2017

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@snikulov @mention-bot @coveralls @bagder