Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gssapi: fix memory leak of output token in multi round context #1733

Closed
wants to merge 1 commit into from

Conversation

iboukris
Copy link
Contributor

@iboukris iboukris commented Aug 4, 2017

When multiple rounds are needed to establish a security context
(usually ntlm), we overwrite old token with a new one without free.
Found by proposed gss tests using stub a gss implementation (by
valgrind error), though I have confirmed the leak with a real
gssapi implementation as well.

(detached from PR #1687)

When multiple rounds are needed to establish a security context
(usually ntlm), we overwrite old token with a new one without free.
Found by proposed gss tests using stub a gss implementation (by
valgrind error), though I have confirmed the leak with a real
gssapi implementation as well.
@mention-bot
Copy link

@Frenche, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @vszakats to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 75.263% when pulling df9415c on frenche:gss_multi_memleak into 54aef85 on curl:master.

Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The Travis failure should hopefully be fixed by #1734.

@MarcelRaad MarcelRaad closed this in 0b11660 Aug 4, 2017
@MarcelRaad
Copy link
Member

Thanks a lot!

@iboukris iboukris deleted the gss_multi_memleak branch August 5, 2017 08:15
@iboukris
Copy link
Contributor Author

iboukris commented Aug 5, 2017

Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants