Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dictserver.py/negtelnetserver.py to EXTRA_DIST #1744

Closed
wants to merge 1 commit into from
Closed

Add dictserver.py/negtelnetserver.py to EXTRA_DIST #1744

wants to merge 1 commit into from

Conversation

atsampson
Copy link
Contributor

The 7.55.0 release's test suite fails owing to missing files:

sh: /src/net/curl/work/curl-7.55.0/tests/dictserver.py: No such file or directory
RUN: failed to start the DICT server
== Contents of files in the log/ dir after test 1450
sh: /src/net/curl/work/curl-7.55.0/tests/negtelnetserver.py: No such file or directory
RUN: failed to start the TELNET server
== Contents of files in the log/ dir after test 1452

This patch should fix it, but it'd also be good to ensure the release process involves running the test suite from the tarball in order to prevent this kind of problem in the future (e.g. "make distcheck").

@atsampson
Add dictserver.py/negtelnetserver.py to EXTRA_DIST
6559f0f 
These weren't included in the 7.55.0 release, but are required in order
to run the test suite.
@mention-bot
Copy link

@atsampson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @sbrokenshire to be potential reviewers.

kdudka
kdudka approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 75.33% when pulling 6559f0f on atsampson:master into a7bbbb7 on curl:master.

@bagder bagder closed this in 7e949de Aug 9, 2017
@bagder
Copy link
Member

bagder commented Aug 9, 2017

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdudka kdudka kdudka approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atsampson @mention-bot @coveralls @bagder @kdudka