New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test 1299 fails on MinGW-w64 #1751
Comments
Curious, it expands the asterisk? Does it work single quotes instead? |
Changing |
I consider that a bug in the msys2 shell, as that's not how shells typically work. Not that it helps much... |
GodEater just commented this on IRC:
|
That's strange. All MinGW autobuilds also show this problem. It seems to be not a problem of the shell only, but also of the C runtime used. Using single quotes AND adding |
So is that the proper solution you think? |
Using single quotes definitely, as that fixes at least the non-MSYS case without breaking other stuff. I'm not 100% sure about changing the globbing behavior as there might be users of the curl tool who rely on it? Also, according to the mingw-w64 source on SourceForge, globbing should be off by default for MinGW-w64 (unlike original MinGW). So I wanted to find out why it's on for my MinGW-w64 curl build, but wasn't successful yet. |
I can't think of any use case for mingw's type of globbing in curl arguments. |
Yes, it's really very broken. The MSYS2 shell does its globbing and then MinGW's CRT does globbing again because the shell removes the quotes. With original MinGW from mingw.org, globbing can be controlled by additional options: |
By default, the MinGW CRT globs command-line arguments. This prevents getting a single asterisk into an argument as test 1299 does. Turn off globbing by setting the global variable _CRT_glob to 0 for MinGW. Fixes curl#1751
The test was added with b778ae4.
Also visible in the autobuilds:
curl/libcurl version
curl 7.54.0 (x86_64-pc-msys) libcurl/7.54.0 OpenSSL/1.0.2k zlib/1.2.11 libssh2/1.7.0
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: Debug IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz TLS-SRP UnixSockets HTTPS-proxy Metalink
operating system
MinGW-w64 on Windows 10
The text was updated successfully, but these errors were encountered: