strtoofft: overhaul to address integer overflow risks globally #1758
+235
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/number-parsing-overhaul
branch
from
c023769 to
b3f3381
Compare
... make sure we bail out on overflows. Reported-by: Brian Carpenter
bagder
force-pushed
the
bagder/number-parsing-overhaul
branch
from
b3f3381 to
ffa73dd
Compare
|
This broke non-MSVC builds that need HAVE_STRTOLL, e.g. https://curl.haxx.se/dev/log.cgi?id=20170825014632-29789#prob8 |
bagder
added a commit
that referenced
this pull request
Aug 25, 2017
Reported-by: Dan Fandrich Bug: #1758 (comment)
|
@dfandrich can you perhaps try out #1829 manually and see if it is good enough for this? |
bagder
added a commit
that referenced
this pull request
Aug 27, 2017
Closes #1829 Reported-by: Dan Fandrich Bug: #1758 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... make sure we bail out on overflows.
Reported-by: Brian Carpenter