Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect: skip URL encoding for host names #1762

Closed
wants to merge 1 commit into from

Conversation

salshaaban
Copy link
Contributor

This fixes redirects to IDN URLs

Bug: #1441
Reported by: David Lord

This fixes redirects to IDN URLs

Bug: curl#1441
Reported by: David Lord
@mention-bot
Copy link

@salshaaban, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @dfandrich and @yangtse to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 75.125% when pulling 636a62b on salshaaban:IDN into 77cd4e7 on curl:master.

@bagder
Copy link
Member

bagder commented Aug 11, 2017

Thanks, I'm working on writing up a test for this. In fact, I already did but the problem now is that the test uses a hard-coded port number in the HTTP response header and that's not how we like to do things, so I need to come up with a solution to that ...

@salshaaban
Copy link
Contributor Author

I'm working on writing up a test for this. In fact, I already did

I should've done that myself. Sorry!
I will try to think of something too.

@bagder
Copy link
Member

bagder commented Aug 12, 2017

check out test1448 (remove the .txt extension)

@bagder
Copy link
Member

bagder commented Aug 12, 2017

Aha! I figured it out. I can use --connect-to, to redirect that port 8990 to the port it is actually on! ... I'll post a separate PR to see what the CI says.

@bagder
Copy link
Member

bagder commented Aug 12, 2017

That's now in #1772

@bagder bagder closed this in d6ecb2c Aug 12, 2017
@bagder
Copy link
Member

bagder commented Aug 12, 2017

Thanks!

@salshaaban salshaaban deleted the IDN branch August 13, 2017 08:51
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants