Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: build the examples too #1777

Closed
wants to merge 1 commit into from
Closed

travis: build the examples too #1777

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 14, 2017

to make sure they keep building warning-free

@bagder
travis: build the examples too
4174dec 
to make sure they keep building warning-free
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 75.063% when pulling 4174dec on bagder/travis-examples into adc35a4 on master.

@MarcelRaad
Copy link
Member

Isn't --enable-werror only for the library and tool? IIRC, the examples and tests always build without warnings-as-errors. But keeping them building at all is an improvement too of course :-)

@bagder
Copy link
Member Author

bagder commented Aug 14, 2017

Yes, I'm mostly concerned that they build at all, I'm not at all convinced that --werror is a good idea for the examples.

@MarcelRaad
Copy link
Member

Ah, I misread the description to mean that. Yes, warnings-as-errors doesn't even work on Windows without complicating the examples because some WinSock function parameter is unsigned int when it should be size_t.

@bagder bagder closed this in b53b4e4 Aug 14, 2017
@bagder bagder deleted the bagder/travis-examples branch August 14, 2017 21:26
@bagder
Copy link
Member Author

bagder commented Aug 14, 2017

Thanks for the review @MarcelRaad

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bagder @coveralls @MarcelRaad