Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh.pl: produce a working completion script again #1779

Closed
wants to merge 1 commit into from
Closed

zsh.pl: produce a working completion script again #1779

wants to merge 1 commit into from

Conversation

kdudka
Copy link
Contributor

@kdudka kdudka commented Aug 14, 2017

Commit curl-7_54_0-118-g8b2f22e changed the output format of curl --help to use <file> and <dir> instead of FILE and DIR, which caused zsh.pl to produce a broken completion script:

% curl --<TAB>
_curl:10: no such file or directory: seconds

@kdudka
zsh.pl: produce a working completion script again
c21b392 
Commit curl-7_54_0-118-g8b2f22e changed the output format of curl --help
to use <file> and <dir> instead of FILE and DIR, which caused zsh.pl to
produce a broken completion script:

% curl --<TAB>
_curl:10: no such file or directory: seconds
@mention-bot
Copy link

@kdudka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @captain-caveman2k and @yangtse to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 75.074% when pulling c21b392 on kdudka:zsh into adc35a4 on curl:master.

bagder
bagder approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kdudka
Copy link
Contributor Author

kdudka commented Aug 15, 2017

Thanks for review! Pushing now...

@kdudka kdudka closed this in ab2a707 Aug 15, 2017
@kdudka kdudka deleted the zsh branch August 15, 2017 10:30
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kdudka @mention-bot @coveralls @bagder