Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: check for __builtin_available() availability #1788

Merged
merged 1 commit into from Aug 16, 2017
Merged

configure: check for __builtin_available() availability #1788

merged 1 commit into from Aug 16, 2017

Conversation

nickzman
Copy link
Member

This change does two things:

  1. It un-breaks the build in Xcode 9.0. (Xcode 9.0 is currently
    failing trying to compile connectx() in lib/connect.c.)
  2. It finally weak-links the connectx() function, and falls back on
    connect() when run on older operating systems.

@nickzman
configure: check for __builtin_available() availability
aee89fa 
This change does two things:
1. It un-breaks the build in Xcode 9.0. (Xcode 9.0 is currently
   failing trying to compile connectx() in lib/connect.c.)
2. It finally weak-links the connectx() function, and falls back on
   connect() when run on older operating systems.
@nickzman nickzman requested review from ghedo and bagder August 15, 2017 21:50
bagder
bagder approved these changes Aug 15, 2017
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I test built on my mac with Xcode 8.3.2 installed and it did not define HAVE_BUILTIN_AVAILABLE and yet the tests ran fine after the build.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 75.048% when pulling aee89fa on nickzman/builtin-available into 774d49a on master.

@nickzman nickzman merged commit 870d849 into master Aug 16, 2017
@nickzman nickzman deleted the nickzman/builtin-available branch August 16, 2017 17:24
ehlertjd pushed a commit to Trustera/curl that referenced this pull request Aug 31, 2017
configure: check for __builtin_available() availability (curl#1788)
cf2b3f6 
This change does two things:
1. It un-breaks the build in Xcode 9.0. (Xcode 9.0 is currently
   failing trying to compile connectx() in lib/connect.c.)
2. It finally weak-links the connectx() function, and falls back on
   connect() when run on older operating systems.
markovicpp pushed a commit to markovicpp/curl that referenced this pull request Nov 15, 2017
@pavolmarkovic-serato
macOS: Fix missing connectx function with Xcode version older than 9.0
63e5f83 
The previous fix curl#1788 worked just for Xcode 9. This commit extends the fix to older Xcode versions effectively by not using connectx function.

Fixes curl#1330
Fixes curl#2080
Closes curl#1336
@markovicpp markovicpp mentioned this pull request Nov 15, 2017
Closed
bagder pushed a commit that referenced this pull request Nov 15, 2017
@pavolmarkovic-serato @bagder
macOS: Fix missing connectx function with Xcode version older than 9.0
6ce9845 
The previous fix #1788 worked just for
Xcode 9. This commit extends the fix to older Xcode versions effectively
by not using connectx function.

Fixes #1330
Fixes #2080
Closes #1336
Closes #2082
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

@ghedo ghedo Awaiting requested review from ghedo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickzman @coveralls @bagder