Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build fails to embed the manifest #1832

Closed
theantigod opened this issue Aug 25, 2017 · 2 comments
Closed

Windows build fails to embed the manifest #1832

theantigod opened this issue Aug 25, 2017 · 2 comments
Labels

Comments

@theantigod
Copy link
Contributor

theantigod commented Aug 25, 2017

I did this

I am currently building curl-7.55.1 for Windows 64bit.
This issue may have been detected but could not find any mention of it.

mt.exe : general error c10100b1: Failed to load file "..\builds\libcurl-vc9-x64-debug-dll\curl.exe". The system cannot find the file specified.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft SDKs\Windows\v6.0A\bin\mt.EXE"' : return code '0x1f' Stop.
NMAKE : fatal error U1077: '"c:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\nmake.exe"' : return code '0x2'

In MakefileBuild.vc:

!IFDEF EMBED_MANIFEST
MANIFESTTOOL = mt -manifest $(DIRDIST)\$(PROGRAM_NAME).manifest -outputresource:$(DIRDIST)\$(PROGRAM_NAME);1
!ENDIF

Needs to be changed: \bin is missing from the 2 paths.

MANIFESTTOOL = mt -manifest $(DIRDIST)\bin\$(PROGRAM_NAME).manifest -outputresource:$(DIRDIST)\bin\$(PROGRAM_NAME);1

@bagder bagder added the build label Aug 25, 2017
@jay jay closed this as completed in 09fc61e Aug 26, 2017
@jay
Copy link
Member

jay commented Aug 26, 2017

Thanks, fixed. I was able to reproduce using these commands in a Visual Studio 2008 x64 command prompt:

cd /d curldir
buildconf.bat
cd winbuild
nmake /f Makefile.vc mode=dll VC=9 ENABLE_IDN=no EMBED_MANIFEST=defined

Where did you find out about EMBED_MANIFEST? It is not documented AFAICT and I don't think anyone's using it in their build scripts or we would have caught this a long time ago.

@theantigod
Copy link
Contributor Author

theantigod commented Aug 26, 2017 via email

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants