New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test651: curl_formadd with huge COPYCONTENTS #1988
Conversation
... shows a bug after the first 16K on 7.56.0 Code-by: Jeroen Ooms
... as verified by test 651
I think that fixes it, just needs to run through the CI to make sure nothing breaks while I run some more tests locally as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups, my bad !
16K is the read buffer size and we had no test with more memory data... good catch.
I completely agree with the fix.
Thanks for the quick fix! Are there plans for a patch release soon, or should i better cherry pick the patch into my deployment? |
I have had discussions with some peeps about about a possible patch release but not properly (ie not on the mailing list) and nothing has been decided yet. And even if we will decide to make one, it will be at a set date at least one week into the future. |
No description provided.