mkhelp.pl: support reproducible build #2026
Conversation
From what I'm reading isn't that variable part of a spec that is supposed to have the seconds in it. See https://reproducible-builds.org/specs/source-date-epoch/ I don't see "date unspecified" covered (though I just did some cursory searching). |
|
Yes, SOURCE_DATE_EPOCH does contain an "epoch" value. So it is tempting to print that value instead of the build time. However, I replicated the approach I have seen in openssl, where they issue an identical message: "reproducible build: date unspecified". Claiming that the "Generation time" is the time specified by SOURCE_DATE_EPOCH would not be entirely true. |
|
Another approach would be not to generate the whole line "Generation time: ..." at all. |
|
I don't think the time string serves any good purpose there so I think the simpler option of just removing it is the better one here! |
|
Remove unconditionally or only when SOURCE_DATE_EPOCH is present? |
|
I say remove unconditionally |
|
OK then. I will create a new pull request. |
Do not generate line with the current date, such as: * Generation time: Tue Oct-24 18:01:41 2017 This will improve reproducibility. The generated string is only part of a comment, so there should be no adverse consequences. Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
|
Excellent, thank you! |
If the environment contains SOURCE_DATE_EPOCH, generate output such as:
Instead of the usual output based on the current date such as:
This will improve reproducibility. The generated string is only
part of a comment, so there should be no adverse consequences.
Signed-off-by: Juro Bystricky juro.bystricky@intel.com