Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imap: deal with commands case insentively #2061

Closed
wants to merge 1 commit into from
Closed

imap: deal with commands case insentively #2061

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Nov 7, 2017

As documented in RFC 3501 section 9:
https://tools.ietf.org/html/rfc3501#section-9

jay
jay requested changes Nov 7, 2017
View reviewed changes
Copy link
Member

@jay jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look right, it looks like you did a search and replace but strcmp is false on match and strcasecompare is true on match.

@bagder
Copy link
Member Author

bagder commented Nov 7, 2017

Doh! I'll amend...

@bagder bagder force-pushed the bagder/imap-case-insensitive branch from e8b0ab0 to bfdf0b4 Compare November 8, 2017 23:26
@bagder bagder closed this in e871ab5 Nov 9, 2017
@bagder bagder deleted the bagder/imap-case-insensitive branch November 9, 2017 09:37
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jay jay jay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @jay