New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl_ctype: private is*() type macros and functions #2269
Conversation
... since the libc provided one are locale dependent in a way we don't want.
Ah, it needs some more polish... |
I have spoken too fast on the mailing list: we have to make provision for EBCDIC support (CURL_DOES_CONVERSION), thus we have to support all values <= 0xFF. EBCDIC uses the full 8-bit range so the table should have 256 entries and a conditional (#if '0' == '\xF0' --> EBCDIC) to enable one table or another. Variants of EBCDIC:
plus many others. AFAIK, only non alnum codes may vary from one CP to another. OS400 libcurl uses ASCII. We should probably ask the TPF maintainer about it. |
I figure EBCDIC gets its own set of functions, or possibly even get to use the original functions. I don't intend to work on those versions since I don't have any such hardware to test on so it'll certainly end up wrong somewhere anyway. |
I get redefinition warnings/errors now on MinGW-MSYS as well as Cygwin:
(Wow, why does my GCC speak German all of a sudden?) |
I think we should probably first #undef all those defines to make sure they're not colliding like for you... |
... since the libc provided one are locale dependent in a way we don't
want.