I don't like how this code adds 6(!) (separate) string comparisons for "pkcs11:". It adds multiple code chunks that look almost identical but they are not. I'm not sure what the fix for this is, but can we think of a nicer way to do this?

Also, should the string check really require the string to be lowercase or should it be done case insensitively?

I don't like how this code adds 6(!) (separate) string comparisons for "pkcs11:". It adds multiple code chunks that look almost identical but they are not. I'm not sure what the fix for this is, but can we think of a nicer way to do this?

Sure, we can try to find the best way. It is possible to write a function to check if a given string is a PKCS#11 URI and at least make a single base code. But it will do the string comparison in the same way. And since different parameters can be independently provided as PKCS#11 URI, I believe that there is no other way than doing it many times in the almost identical way. That would result in substituting the lines:

if(!strncmp(<some_string>, "pkcs11:", 7)) {

for

if(is_pkcs11_uri(<some_string>)) {

where is_pkcs11_uri() is defined as:

static bool is_pkcs11_uri(const char * string) {
  return !strncmp(string, "pkcs11:", 7);
}

But the other lines will remain the same. This would (potentially) add a function call overhead in exchange for the unified location for the check. Do you have any suggestion to improve this?

Also, should the string check really require the string to be lowercase or should it be done case insensitively?

According to RFC 7512, yes, it must be lowercase.

According to RFC 7512, yes, it must be lowercase

Where does it say that? It refers to the string being a URI and "pkcs11" being a URI scheme. URIs are defined by RFC 3986 which says:

Although schemes are case-insensitive, the canonical form is lowercase and documents that specify schemes must do so with lowercase letters.

RFC 4395 in turn defines how to register URI schemes and it says:

Note that although scheme names are case insensitive, scheme names MUST be registered using lowercase letters.

You are right, I was not aware about it. Thank you, I will be more careful with my affirmations.
This same issue is present in OpenSC/libp11 (they consider it case sensitive in the same way I did). I will open an issue for them.

It seems it have to be fixed in tool_getparam.c, line 340, too.

I will use the functions provided in strcase.h instead. Is it OK?

And I do not like the way I did, duplicating the is_pkcs11_uri() function in two places (in lib/vtls/openssl.c and src/tool_operate.c). Is it possible to do it in one place shared between libcurl and curl? In which file should this function be?

Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1219544

That patch looks like a good way forward in two aspects

1. unifying curl with the two back-ends that support PKCS#11 URIs (openssl and gnutls)
2. (most important) Allowing PKCS#11 URIs to be used in the place of files to specify certificates and private keys; that's a goal we have in Fedora

• https://fedoraproject.org/wiki/PackageMaintainers/PKCS11
• https://fedoraproject.org/wiki/PackagingDrafts/Pkcs11Support

Bottom line, it would be great if that would be merged!

Thanks!