Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwinssl: fix iOS build #2397

Merged
merged 1 commit into from Mar 18, 2018
Merged

darwinssl: fix iOS build #2397

merged 1 commit into from Mar 18, 2018

Conversation

chris-araman
Copy link
Contributor

Discussion in #2396.

@bagder bagder requested a review from nickzman March 17, 2018 21:14
@bagder bagder added the TLS label Mar 17, 2018
Copy link
Member

@nickzman nickzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Guess what I forgot to check last time?

@chris-araman
Copy link
Contributor Author

Who needs build automation when you have such a huge community of users? ;)

@bagder
Copy link
Member

bagder commented Mar 18, 2018

We CI all PRs and commits to the best of our abilities! At the same time, curl is built and used on a ridiculous amount of operating systems and 3rd party library combinations so we cannot ever expect to test them all before shipped.

@bagder bagder merged commit b7b2809 into curl:master Mar 18, 2018
@chris-araman
Copy link
Contributor Author

I understand. It’s a huge matrix. Thanks for getting the fix in quickly.

@chris-araman chris-araman deleted the issue-2396 branch March 18, 2018 17:40
@lock lock bot locked as resolved and limited conversation to collaborators Jun 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants