Winbuild: Updated BUILD.WINDOWS.txt to reflect more recent data #2472
Conversation
kdekker
commented
Apr 9, 2018
kdekker
commented
- Use URLs that point to newer versions of SDKs/documentation
- Updated text to reflect more recent Visual Studio versions (2015 and 2017)
Due to the check in Makefile.vc and MakefileBuild.vc, no make call can be invoked unless a build-type was specified. However, a clean target only existed when a build type was specified. As a result, the clean target was unreachable. Made clean target unconditional.
In modern Windows versions and/or more recent Visual Studio compilers, no setenv command exists. The way to open a CMD prompt with right settings is either done by vcvarsall.bat or VsDevCmd.bat. Also updated URLs to more recent SDK versions. The SDK is no longer called "platform SDK" but "Windows SDK" (by Microsoft).
This reverts commit d01d6e3.
This reverts commit 985c140.
This reverts commit d01d6e3.
This reverts commit 2418a5d.
This reverts commit 985c140.
This reverts commit d01d6e3.
This reverts commit 985c140.
This reverts commit 29ce9f4.
The documentation was quite outdated. The setenv command no longer exists and visual studio build prompts got changed. Used Visual Studio 2015/2017 as reference.
|
This PR has 11 irrelevant commits and 1 that you want merged... |
|
I cherry-picked the single patch and merged that now. Please also check our template for commit messages, as that makes it even easier for us to receive your changes. Thanks! |
|
I reverted all on master branch of my own clone + forced (based on the comments of Marcel Raad) a sync with the remote repository. I don't know how to find your template. I'm almost struggling for 3 days how to create a PR. I understand that you have not that much time to explain, but just 'check our template' causes me to spend very much time, on just a simple documentation change. It requires really much courage (and time) to contribute to curl... I'm a little bit disappointed how much. It would be great if you can provide an URL to the mentioned template. |
To me, it seems this time you speak of is mostly you not knowing the primary tool we use: git. I don't know what we can do to make that ride easier... Also, making PRs on github is widely documented on github and elsewhere and also a procedure that is shared by millions of projects so lots of users already know how, plus once you've learned you'll be able to use this knowledge in many other projects. The preferred commit message style is described in the regular contribute page. See the "Write good commit messages" subtitle. |
| @@ -12,7 +12,7 @@ Building with Visual C++, prerequisites | |||
|
|
|||
| The latest Platform SDK can be downloaded freely from: | |||
|
|
|||
| https://msdn.microsoft.com/en-us/windows/bb980924 | |||
| https://developer.microsoft.com/nl-nl/windows/downloads/sdk-archive | |||
There was a problem hiding this comment.
en-us would probably be understood by more people than nl-nl ;-)
|
You are right. Unfortunately, the MS website is doing this 'automagically'. If this change was already committed on the master branch of the cURL repository, I will create a new PR and fix this URL. If this change was not yet committed, I will create a new branch in my own fork, and also create a new PR. If I understood Daniel's comments, this change is as #73070e8 on the master? But as I made already some other mistakes, I really like to get a confirmation. |
|
Ah, you're right, this is already in master. You will get it by doing a |
|
Fixed now by filing a new PR (see above). |
