Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not unconditionally add gcc-specific flags #2576

Closed
wants to merge 1 commit into from
Closed

Do not unconditionally add gcc-specific flags #2576

wants to merge 1 commit into from

Conversation

dago
Copy link
Contributor

@dago dago commented May 16, 2018

The warning flag leads e.g. Sun Studio compiler to bail out.

@dago
Do not unconditionally add gcc-specific flags
9f3e919 
The warning flag leads e.g. Sun Studio compiler to bail out.
bagder
bagder approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully agreed, that slipped in by mistake!

@bagder
Copy link
Member

bagder commented May 16, 2018

Thanks!

@bagder bagder closed this in d9e92fd May 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dago @bagder