Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winbuild: In MakefileBuild.vc fix typo DISTDIR->DIRDIST #2603

Closed
wants to merge 1 commit into from
Closed

winbuild: In MakefileBuild.vc fix typo DISTDIR->DIRDIST #2603

wants to merge 1 commit into from

Conversation

richardthe3rd
Copy link
Contributor

I assume this is a simple typo. This is the only place that uses $(DISTDIR) and $(DIRDIST) is used everywhere else in the file.

@bagder
Copy link
Member

bagder commented May 24, 2018

Did you intend to submit three commits and not only the last one?

@bagder bagder added build Windows Windows-specific labels May 24, 2018
@richardthe3rd
winbuild: In MakefileBuild.vc fix typo DISTDIR->DIRDIST
80686ba 
Change requirement from $(DISTDIR) to $(DIRDIST)
@richardthe3rd richardthe3rd force-pushed the richardthe3rd-winbuild-dirdist-typo branch from 58b59be to 80686ba Compare May 24, 2018 20:36
@richardthe3rd
Copy link
Contributor Author

I didn't mean to. Cleaned it up.

@bagder
Copy link
Member

bagder commented May 27, 2018

Thanks!

@bagder bagder closed this in 75c51e0 May 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
build Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richardthe3rd @bagder