Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURLOPT_SSL_VERIFYPEER.3: Add performance note #2673

Closed
wants to merge 1 commit into from

Conversation

pschlan
Copy link
Contributor

@pschlan pschlan commented Jun 21, 2018

As a follow-up to PR #2290, extend the documentation of CURLOPT_SSL_VERIFYPEER to give a hint that verification will still be performed even though CURLOPT_SSL_VERIFYPEER is 0.

expensive, especially when dealing with many connections. Thus, in some
situations, you might want to disable verification fully to save resources
by setting \fICURLOPT_CAINFO(3)\f to NULL - but please also consider the
warning above!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should rather say that it still might (depending on TLS backend) load the certificates. I don't think saying "it will verify but ignore the result" helps the user even if it technically is true. This is an area I want to make sure people will not misunderstand so I rather not mention "verify" where it doesn't actually verify...

@pschlan
Copy link
Contributor Author

pschlan commented Jun 22, 2018

Thanks for your comment, highly appreciated. I've tried to rephrase it and pushed a new version.

@bagder
Copy link
Member

bagder commented Jun 23, 2018

Thanks!

@bagder bagder closed this in b6a16af Jun 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants