Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update confusing example of using CURLINFO_TLS_SSL_PTR #2690

Closed
wants to merge 2 commits into from
Closed

Update confusing example of using CURLINFO_TLS_SSL_PTR #2690

wants to merge 2 commits into from

Conversation

AdrianPeniak
Copy link
Contributor

Previous example was little bit confusing, because SSL* structure (or other "in use" SSL connection pointer) are not accessible after transfer, therefore working with raw TLS library specific pointer should be done during transfer.

@AdrianPeniak
Update confusing example of using
3c3efdf 
Previous example was little bit confusing, because SSL* structure (or other "in use" SSL connection pointer) are not accessible after transfer, therefore working with raw TLS library specific pointer should be done during transfer.
@AdrianPeniak AdrianPeniak changed the title Update confusing example of using Update confusing example of using CURLINFO_TLS_SSL_PTR Jun 28, 2018
bagder
bagder approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is better. Two nits:

  1. it mixes code-style (brace position)
  2. I think we can skip the (void) lines to shorten it

@AdrianPeniak
Fix of proposed changes
ddfe825 
Unify brackets & remove unused (void) lines
@bagder
Copy link
Member

bagder commented Jun 28, 2018

Thanks! (I edited it slightly before merge)

@bagder bagder closed this in 24cb114 Jun 28, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
documentation TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AdrianPeniak @bagder