CMake: Remove redundant code #2715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzakrzewski
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
I cannot test it at the moment but since the CMake builds completed there cannot be subtle typos.
The PR basically cleans up old (long obsolete) block syntax, which is good for readability.
I'd only change the commit message to say exactly that instead of "Remove redundant code".
Do you want me to update pull request or you can do it yourself by cherry-picking? If you want me to update the commit summary can you write exaclty what message you think is some appropriate here. |
|
Thanks. I merged and edited the commit message before I pushed. |
falconindy
pushed a commit
to falconindy/curl
that referenced
this pull request
Sep 10, 2018
Reviewed-by: Jakub Zakrzewski Closes curl#2715
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.