windows: fix version checking #2792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because 10.0 >= 6.3
|
Thanks for the patch! |
MarcelRaad
approved these changes
Jul 25, 2018
|
Note: it's probably easier for you to create PRs from branches other than master. Otherwise, you will have to check out the master branch again to base an eventual next PR on after this one is merged. |
|
D'oh. I didn't check if that code is ever used. I just noticed it while reading code and it looked wrong. |
xquery
pushed a commit
to xquery/curl
that referenced
this pull request
Aug 9, 2018
In the current version, VERSION_GREATER_THAN_EQUAL 6.3 will return false when run on windows 10.0. This patch addresses that error. Closes curl#2792
falconindy
pushed a commit
to falconindy/curl
that referenced
this pull request
Sep 10, 2018
In the current version, VERSION_GREATER_THAN_EQUAL 6.3 will return false when run on windows 10.0. This patch addresses that error. Closes curl#2792
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version, VERSION_GREATER_THAN_EQUAL 6.3 will return false when run on windows 10.0. This patch addresses that error.