Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--disable-symbol-hiding not working anymore? #2830

Closed
MoMuBud opened this issue Aug 2, 2018 · 2 comments
Closed

--disable-symbol-hiding not working anymore? #2830

MoMuBud opened this issue Aug 2, 2018 · 2 comments
Labels
build regression

Comments

@MoMuBud
Copy link

MoMuBud commented Aug 2, 2018

when configuring curl with "--disable-symbol-hiding" it used to expose the functions

"Curl_base64_encode" and "Curl_base64_decode"

nm ./lib/.libs/libcurl.so | grep encode

[2051] | 68028| 72|FUNC |GLOB |0 |12 |Curl_base64_encode
[2542] | 68100| 72|FUNC |GLOB |0 |12 |Curl_base64_decode

Somewhere along the way this behaviour changed and with the current version 7.61.0 they are no longer exposed and "nm" command shows that they are classified as "LOCL".

For more details please look at the discussion: https://curl.haxx.se/mail/lib-2018-07/0136.html
where Dan Fandrich shares more inside details.
@bagder
Copy link
Member

bagder commented Aug 2, 2018

@dfandrich also found out that libtool is to blame

@bagder bagder added the build label Aug 2, 2018
@bagder
Copy link
Member

bagder commented Aug 2, 2018

The offending commit that caused the regression (found by @dfandrich): 4b41424

bagder added a commit that referenced this issue Aug 2, 2018
@bagder
lib/Makefile: only do symbol hiding if told to
0a82aba 
This restores the ability to build a static lib with
--disable-symbol-hiding and yet keep non-curl_ symbols.

Reported-by: Ran Mozes
Fixes #2830
@bagder bagder mentioned this issue Aug 2, 2018
Closed
@bagder bagder closed this as completed in 7279c47 Aug 3, 2018
xquery pushed a commit to xquery/curl that referenced this issue Aug 9, 2018
@bagder @xquery
lib/Makefile: only do symbol hiding if told to
b6a2239 
This restores the ability to build a static lib with
--disable-symbol-hiding to keep non-curl_ symbols.

Researched-by: Dan Fandrich
Reported-by: Ran Mozes
Fixes curl#2830
Closes curl#2831
falconindy pushed a commit to falconindy/curl that referenced this issue Sep 10, 2018
@bagder @falconindy
lib/Makefile: only do symbol hiding if told to
2d633e7 
This restores the ability to build a static lib with
--disable-symbol-hiding to keep non-curl_ symbols.

Researched-by: Dan Fandrich
Reported-by: Ran Mozes
Fixes curl#2830
Closes curl#2831
@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build regression
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bagder @MoMuBud