Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntlm_wb: Fix memory leaks in ntlm_wb_response errorcases #2966

Closed
wants to merge 2 commits into from
Closed

ntlm_wb: Fix memory leaks in ntlm_wb_response errorcases #2966

wants to merge 2 commits into from

Conversation

danielgustafsson
Copy link
Member

When erroring out on either realloc failure, or a request being too large the existing buffer was leaked. Fix by adding a fail clause and free the buffer on the way out.

@danielgustafsson
ntlm_wb: Fix memory leaks in ntlm_wb_response
0090e78 
When erroring out on either realloc failure, or a request being
too large, the existing buffer was leaked. Fix by adding a fail
clause and free the buffer on the way out.

Closes: curl#2966
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
@danielgustafsson
Fixup, will be squashed
69acd9f
@danielgustafsson
Copy link
Member Author

This patch was actually wrong, it erroneously introduced a double-free on Curl_saferealloc() failure, pushed an updated fix to be squashed before pushing.

@danielgustafsson
Copy link
Member Author

None of the errors are related to the PR in question, seems mostly relate to Github flakiness

@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielgustafsson @bagder