Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: don't require OpenSSL if CMAKE_USE_OPENSSL=OFF #3001

Closed
wants to merge 1 commit into from
Closed

cmake: don't require OpenSSL if CMAKE_USE_OPENSSL=OFF #3001

wants to merge 1 commit into from

Conversation

slodki
Copy link
Contributor

@slodki slodki commented Sep 15, 2018 •
edited

User must have OpenSSL installed even if not used by libcurl at all since 7.61.1 release.
Broken at 7867aaa
More complex solution in #2849 (including this fix)

@slodki slodki mentioned this pull request Sep 15, 2018
Closed
9 tasks
@slodki
cmake: don't require OpenSSL if USE_OPENSSL=OFF
cba1d6e 
User must have OpenSSL installed even if not used by libcurl at all since 7.61.1 release.
Broken at 7867aaa
@bagder bagder added the cmake label Sep 16, 2018
snikulov
snikulov approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@snikulov snikulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bagder
Copy link
Member

bagder commented Sep 18, 2018

Thanks!

@bagder bagder closed this in 71b3c67 Sep 18, 2018
@snikulov snikulov mentioned this pull request Sep 26, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@snikulov snikulov snikulov approved these changes

Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slodki @bagder @snikulov