Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtls: Values stored to but never read #3176

Closed
wants to merge 2 commits into from
Closed

gtls: Values stored to but never read #3176

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Oct 26, 2018

Detected by clang-tidy

@bagder bagder force-pushed the bagder/gtls-values-never-read branch from 9fd4ffa to 751f1ac Compare October 26, 2018 07:50
danielgustafsson
danielgustafsson approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bagder bagder closed this in ebfe02f Oct 26, 2018
bagder pushed a commit that referenced this pull request Oct 26, 2018
@danielgustafsson @bagder
openssl: make 'done' a proper boolean
6834846 
Closes #3176
@bagder bagder deleted the bagder/gtls-values-never-read branch October 26, 2018 11:51
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielgustafsson danielgustafsson danielgustafsson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @danielgustafsson