implement CURLOPT_CURLU #3227
implement CURLOPT_CURLU #3227
Conversation
|
I think appveyor borked due to other reasons ...will nudge with doc change |
docs/libcurl/opts/CURLOPT_CURLU.3
Outdated
| @@ -29,7 +29,7 @@ CURLOPT_CURLU \- set URL with CURLU * | |||
| CURLcode curl_easy_setopt(CURL *handle, CURLOPT_CURLU, void *pointer); | |||
| .SH DESCRIPTION | |||
| Pass in a pointer to the \fIURL\fP to work with. The parameter should be a | |||
| CURLU *. | |||
| CURLU *. Setting CURLOPT_CURLU will explicitly override CURLOPT_URL. | |||
There was a problem hiding this comment.
if you write them as \fICURLOPT_CURLU(3)\fP and \fICURLOPT_URL(3)\fP they will appear suitably highlighted in man pages and hyperlinked on the web pages.
docs/libcurl/opts/CURLOPT_CURLU.3
Outdated
| .SH RETURN VALUE | ||
| Returns CURLE_OK if the option is supported, and CURLE_UNKNOWN_OPTION if not. | ||
| .SH "SEE ALSO" | ||
| .BR CURLOPT_URL "(3), |
There was a problem hiding this comment.
maybe also some of the URL API functions can be mentioned in the SEE ALSO?
|
If you rebase and force-push, you can get the merge conflict resolved and all test should be able to run green now. |
xquery
force-pushed
the
curlopt_curlu8
branch
from
7359183
to
d8e8e7e
Compare
|
Can you please specify in doc Is it possible change URL after CULR_URLU was set. |
seems reasonable, though will be the subject of a different PR if we do it. |
|
I think that feature is implied but maybe we should spell it out better. And possibly also spell out that the handle is used read-only by libcurl itself... |
Implement CURLOPT_CURLU (as per https://github.com/curl/curl/wiki/URL-API) so one may pass via curl_easy_setopt aka:
CURL *handle;
CURLU *urlp;
CURLUcode uc;
urlp = curl_url();
uc = curl_url_set(urlp, CURLUPART_URL, "http://example.com/path/index.html", 0);
curl_easy_setopt(handle, CURLOPT_CURLU, urlp);
...
this approach expands on the prior attempts ( #3128, #3160,#3188) ... updated docs (CURLOPT_CURLU.3) to highlight override behavior as well as adding demonstration of this in libtest658.c.
ps - yes, git push --force is now my friend