CMake: fix MIT/Heimdal Kerberos detection #3316
Conversation
- fix syntax error in FindGSS.cmake - correct krb5 include directory. FindGSS exports "GSS_INCLUDE_DIR" variable.
|
@jzakrzewski can you review, also should we be sending these changes upstream somewhere or is this exclusively curl? And what is this comment: Line 149 in 1966771 |
|
@jay I'm pretty sure I've found the base version of it roaming somewhere on the Internet or compiled it somehow (I have, ofc, checked the licence back then and complied as I always do). But there are some curl-specific modification (the comments about autotools are mine I guess). Right now many versions of this one can find on the net come from various copies of curl. So I don't believe there's "upstream" for it. The comment looks a bit like something I could have written (you wouldn't believe what I leave in my company's code sometimes ;) ). It only expresses joy that we've got GSS :D As for the changes - they look correct. I haven't build curl with GSS for a longer while but it seems it must have been quite broken since 4d60e12 (and the spaces in find module were indeed missing, probably causing some warnings). |
|
Thanks guys |
"GSS_INCLUDE_DIR" variable.