Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigpipe: if MBEDTLS is used, force curl to ignore sigpipe. #3502

Closed
wants to merge 1 commit into from

Conversation

JeremieRapin
Copy link

mbedtls doesn't have a sigpipe management.
If a write/read occurs when the remote closes the socket, the signal is raised and kills the application.
Use the curl mecanisms fix this behavior.

Signed-off-by: Jeremie Rapin j.rapin@overkiz.com

mbedtls doesn't have a sigpipe management.
If a write/read occurs when the remote closes the socket, the signal is raised and kills the application.
Use the curl mecanisms fix this behavior.

Signed-off-by: Jeremie Rapin <j.rapin@overkiz.com>
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Assuming this is true, the fix looks fine. I tried to find some docs about this regarding mbedTLS but failed so I will just trust you that this is the case.

@JeremieRapin
Copy link
Author

If it can help you, a sigpipe management appears in object net_sockets.
This piece of code is defined by:

provides an example integration of the Mbed TLS library into a BSD sockets implementation. The module is intended to be an example of how Mbed TLS can be integrated into a networking stack, as well as to be Mbed TLS's network integration for its supported platforms.

@bagder
Copy link
Member

bagder commented Jan 28, 2019

Thanks!

@bagder bagder closed this in a9d9a3a Jan 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants