Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strerror: make the strerror function use local buffers #3612

Closed
wants to merge 4 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 25, 2019

Instead of using a fixed 256 byte buffer in the connectdata struct.

In my build, this reduces the size of the connectdata struct by 11.8%,
from 2160 to 1904 bytes with no functionality or performance loss.

bagder and others added 4 commits February 25, 2019 18:16
Instead of using a fixed 256 byte buffer in the connectdata struct.

In my build, this reduces the size of the connectdata struct by 11.8%,
from 2160 to 1904 bytes with no functionality or performance loss.
squashme into #3612

this also fixes a bug in schannel's Curl_verify_certificate where it
called Curl_sspi_strerror when it should have called Curl_strerror for
string from GetLastError. the only affect would have been no text or the
wrong text being shown for the error.
@jay
Copy link
Member

jay commented Feb 25, 2019

s/affect/effect in my squash

@bagder bagder closed this in 880cd5d Feb 26, 2019
@bagder bagder deleted the bagder/strerror-buffer branch February 26, 2019 09:22
@bagder
Copy link
Member Author

bagder commented Feb 26, 2019

Thanks for the great assistance @jay!

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants