Avoid unportable `==' test(1) operator in configure.ac #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, how silly. How did you catch this? Thinking what we should do to catch the next mistake like this... |
|
Hello Daniel,
Daniel Stenberg writes:
Oops, how silly. How did you catch this? Thinking what we should do to catch the next mistake like this...
In pkgsrc this is taken care by the infrastructure
mk/check/check-portability.* makefile^[0] and scripts^[1][2].
check-portability.sh generate a list of files and checks are done
via check-portability.awk.
I think that they are probably easy to adapt also outside pkgsrc
and in my experience it's pretty rare that they report any false
positive (at least I don't recall any in the more than a decade
:)).
[0]: <https://github.com/NetBSD/pkgsrc/blob/trunk/mk/check/check-portability.mk>
[1]: <https://github.com/NetBSD/pkgsrc/blob/trunk/mk/check/check-portability.sh>
[2]: <https://github.com/NetBSD/pkgsrc/blob/trunk/mk/check/check-portability.awk>
|
|
Debian also has the checkbashisms script (in the devscripts package) that does
something similar.
|
|
I tried checkbashisms (from the Debian devscripts package, version 2.19.4) but when I run it against |
|
Thanks! |
|
Had the same issue on HP-UX: |
|
@michael-o in 7.65.0 ? |
|
@bagder No, just tried 7.65.0 and it is fine now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating www/curl package in pkgsrc the pkgsrc checks spotted
the non-portable
==operator (=can be used instead).