Fix several typos #3724
Fix several typos #3724
Conversation
|
Hmmm... also AFAIK the impacket is just copied Python module and as such should probably be left alone. |
rockdaboot
force-pushed
the
tmp-fix-typos
branch
from
1b63c11
to
a0c3c88
Compare
|
@jzakrzewski Thanks for review. Could you point out which files / directories in the repo are copied (=will be overwritten eventually) and where they come from ? I would put them as exceptions into the spellcheck script, also it might be a good idea to report the typos upstream. |
|
Well, at least everything in the tests/python_dependencies/impacket. I'm not aware of anything else at the moment. |
|
Sure, let's see what tomorrow brings... |
| @@ -1586,7 +1586,7 @@ static CURLcode myssh_statemach_act(struct connectdata *conn, bool *block) | |||
| return CURLE_BAD_DOWNLOAD_RESUME; | |||
| } | |||
| } | |||
| /* Does a completed file need to be seeked and started or closed ? */ | |||
There was a problem hiding this comment.
I know seeked isn't the correct spelling, but in this case I'm ready to give it the benefit of being wrong since it's referring to the specific seek call.. The current spelling, in all it's typoness, convey meaning.
There was a problem hiding this comment.
Reasonable, I'll revert it tomorrow.
| @@ -2232,7 +2232,7 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block) | |||
| return CURLE_BAD_DOWNLOAD_RESUME; | |||
| } | |||
| } | |||
| /* Does a completed file need to be seeked and started or closed ? */ | |||
| /* Does a completed file need to be sought and started or closed ? */ | |||
There was a problem hiding this comment.
Same as above ;-)
| @@ -815,7 +815,7 @@ def recv_packet(self, timeout = None): | |||
| # The next loop is a workaround for a bigger problem: | |||
| # When data reaches higher layers, the lower headers are lost, | |||
| # and with them, for example, the source IP. Hence, SMB users | |||
| # can't know where packets are comming from... we need a better | |||
There was a problem hiding this comment.
impacket is vendored code and should remain untouched, please submit these to the upstream project.
There was a problem hiding this comment.
See conversation above
|
No need to spend the effort of rebasing this for such small details, I fixed up the commit for you and pushed. Thanks for your contribution! |
|
Nice, thank you ! |
Please let me know if you prefer a more detailed commit message.
The spell-checking script follows tomorrow...