Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 compatibility for Impacket tests #3731

Closed
wants to merge 1 commit into from
Closed

Python 3 compatibility for Impacket tests #3731

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 4, 2019

https://github.com/SecureAuthCorp/impacket now supports Python 3 so this PR moves the Impacket test cases here towards Python 3 compatibility.

@bagder
Copy link
Member

bagder commented Apr 5, 2019

Codacy complaints on this can be ignored since we only use this code when running tests. I'll check if I can somehow whitelist this...

@bagder
Copy link
Member

bagder commented Apr 6, 2019

Thanks!

@bagder bagder closed this in aba1c51 Apr 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cclauss @bagder