urlapi: add CURLUPART_ZONEID to set and get #3834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zoneid can be used with IPv6 numerical addresses. Updated test 1560 to verify.
|
I think this should have waited until next feature window, I assumed that's why you did it separately. |
|
That was my original intention too. I went back and forth on it and the fact that we can't extract the zone id from the URL is an actual bug and I finally landed it since I figured the risk is still minimal and with this landed, we can actually also fix the zoneid bugs we have internally using the proper parsing API... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zoneid can be used with IPv6 numerical addresses.
Updated test 1560 to verify.